fix!: Remove the blocklyMenuItemHighlight CSS class and use the hover#8536
Merged
BeksOmega merged 3 commits intoRaspberryPiFoundation:rc/v12.0.0from Aug 21, 2024
Conversation
github-actions
bot
added
breaking change
BeksOmega
suggested changes
Aug 19, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
This looks much better! Just one fix then should be gtg =) Thank you for your continued work on this!
core/menuitem.ts
Outdated
| @@ -185,15 +183,6 @@ export class MenuItem { | |||
| */ | |||
| setHighlighted(highlight: boolean) { | |||
Contributor
There was a problem hiding this comment.
Can you actually delete this method entirely? It's internal and this.highlight is private, so removing it isn't a breaking change =)
Arun-cn
force-pushed
the
fix/8327-remove-blocklymenuitemhighlight
branch
from
9ab8959 to
fd4594f
Compare
BeksOmega
approved these changes
Aug 20, 2024
Contributor
BeksOmega
left a comment
BeksOmega
left a comment
There was a problem hiding this comment.
One last fix then LGTM!
core/css.ts
Outdated
| background-color: rgba(0,0,0,.1); | ||
| } | ||
|
|
||
| /* State: hover. */ |
Contributor
There was a problem hiding this comment.
Sorry I missed this, could you delete this CSS as well? The .blocklyMenuItemHighlight not the .blocklyMenuItem:hover
Contributor
|
Thank you again for all of your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes Remove blocklyMenuItemHighlight CSS class and use :hover CSS selector #8327
Proposed Changes
Remove the blocklyMenuItemHighlight CSS class from the menu item.
Use the :hover CSS pseudo class in css.ts.
Reason for Changes
Test Coverage
Documentation
Additional Information